Changeset 1122

Timestamp:

10/16/08 21:57:53 (3 months ago)

Author:

laurentj

Message:

ticket #718: jForms: space only values on required fields do not fire errors. patch on the 1.0.x branch. p=bibo

Files:

• branches/1.0.x/lib/jelix-www/js/jforms.js (modified) (2 diffs)
• branches/1.0.x/lib/jelix/forms/jFormsControl.class.php (modified) (4 diffs)
• branches/1.0.x/testapp/modules/jelix_tests/tests/jforms.check_datas.html_cli.php (modified) (2 diffs)
• trunk/lib/jelix/forms/jFormsControl.class.php (modified) (2 diffs)

branches/1.0.x/lib/jelix-www/js/jforms.js

@@ -3 +3 @@
-* @subpackage   forms
-* @author       Laurent Jouanneau
-
+, Dominique Papin
-* @copyright    2007 Laurent Jouanneau
-
+, 2008 Dominique Papin
-* @link         http://www.jelix.org
-* @licence      GNU Lesser General Public Licence see LICENCE file or http://www.gnu.org/licenses/lgpl.html
@@ -60 +60 @@
-            if (!elt) continue; // sometimes, all controls are not generated...
-            var val = this._getValue(elt);
-
+
+
+
+
-                if(c.required){
-                    f.errorDecorator.addError(c, 1);

branches/1.0.x/lib/jelix/forms/jFormsControl.class.php

@@ -5 +5 @@
-* @author      Laurent Jouanneau
-* @contributor Loic Mathaud, Dominique Papin
-
+-2008
-* @copyright   2007 Loic Mathaud
-* @link        http://www.jelix.org
@@ -39 +39 @@
-
-    function check($value, $form){
-$value
+trim($value)
-            if($this->required)
-                return jForms::ERRDATA_REQUIRED;
@@ -115 +115 @@
-            }
-        }else{
-$value
+trim($value)
-                if($this->required)
-                    return jForms::ERRDATA_REQUIRED;
@@ -165 +165 @@
-            }
-        }else{
-$value
+trim($value)
-                return jForms::ERRDATA_REQUIRED;
-            }elseif(!$this->datatype->check($value)){

branches/1.0.x/testapp/modules/jelix_tests/tests/jforms.check_datas.html_cli.php

@@ -4 +4 @@
-* @subpackage  unittest module
-* @author      Jouanneau Laurent
-
-
+ Dominique Papin
+, 2008 Dominique Papin
-* @link        http://www.jelix.org
-* @licence     GNU Lesser General Public Licence see LICENCE file or http://www.gnu.org/licenses/lgpl.html
@@ -45 +45 @@
-        $this->assertFalse($this->form->check());
-        $this->form->setData('nom','');
+        $this->assertFalse($this->form->check());
+        $this->form->setData('nom','    ');
-        $this->assertFalse($this->form->check());
-        $ctrl->required = false;

trunk/lib/jelix/forms/jFormsControl.class.php

@@ -458 +458 @@
-            }
-        }else{
-$value
+trim($value)
-                if($this->required)
-                    return $this->container->errors[$this->ref] = jForms::ERRDATA_REQUIRED;
@@ -493 +493 @@
-            }
-        }else{
-$value
+trim($value)
-                return $this->container->errors[$this->ref] = jForms::ERRDATA_REQUIRED;
-            }