Changeset 603

Timestamp:

10/01/07 17:56:44 (1 year ago)

Author:

laurentj

Message:

fixed bug #292, jControllerDaoCrud: previous errors in a form for creation, were not erased in some case. Added a new action, precreate, to fix it

Files:

• branches/1.0beta3.x/lib/jelix/controllers/jControllerDaoCrud.class.php (modified) (2 diffs)
• branches/1.0beta3.x/lib/jelix/controllers/jControllerDaoCrud.class.php (modified) (2 diffs)
• trunk/lib/jelix/controllers/jControllerDaoCrud.class.php (modified) (2 diffs)
• trunk/lib/jelix/controllers/jControllerDaoCrud.class.php (modified) (2 diffs)

branches/1.0beta3.x/lib/jelix/controllers/jControllerDaoCrud.class.php

@@ -167 +167 @@
-        $tpl->assign('controls',$form->getControls());
-        $tpl->assign('editAction' , $this->_getAction('preupdate'));
-
+pre
-        $tpl->assign('deleteAction' , $this->_getAction('delete'));
-        $tpl->assign('viewAction' , $this->_getAction('view'));
@@ -190 +190 @@
-    protected function _index($resp, $tpl) {
-
+    }
+
+    /**
+     * prepare a form to create a record.
+     */
+    function precreate() {
+        // we cannot create the form directly in the create action
+        // because if the forms already exists, we wouldn't show
+        // errors or already filled field. see ticket #292
+        $form = jForms::create($this->form);
+        $rep = $this->getResponse('redirect');
+        $rep->action = $this->_getAction('create');
+        return $rep;
-    }
-

branches/1.0beta3.x/lib/jelix/controllers/jControllerDaoCrud.class.php

@@ -167 +167 @@
-        $tpl->assign('controls',$form->getControls());
-        $tpl->assign('editAction' , $this->_getAction('preupdate'));
-
+pre
-        $tpl->assign('deleteAction' , $this->_getAction('delete'));
-        $tpl->assign('viewAction' , $this->_getAction('view'));
@@ -190 +190 @@
-    protected function _index($resp, $tpl) {
-
+    }
+
+    /**
+     * prepare a form to create a record.
+     */
+    function precreate() {
+        // we cannot create the form directly in the create action
+        // because if the forms already exists, we wouldn't show
+        // errors or already filled field. see ticket #292
+        $form = jForms::create($this->form);
+        $rep = $this->getResponse('redirect');
+        $rep->action = $this->_getAction('create');
+        return $rep;
-    }
-

trunk/lib/jelix/controllers/jControllerDaoCrud.class.php

@@ -167 +167 @@
-        $tpl->assign('controls',$form->getControls());
-        $tpl->assign('editAction' , $this->_getAction('preupdate'));
-
+pre
-        $tpl->assign('deleteAction' , $this->_getAction('delete'));
-        $tpl->assign('viewAction' , $this->_getAction('view'));
@@ -190 +190 @@
-    protected function _index($resp, $tpl) {
-
+    }
+
+    /**
+     * prepare a form to create a record.
+     */
+    function precreate() {
+        // we cannot create the form directly in the create action
+        // because if the forms already exists, we wouldn't show
+        // errors or already filled field. see ticket #292
+        $form = jForms::create($this->form);
+        $rep = $this->getResponse('redirect');
+        $rep->action = $this->_getAction('create');
+        return $rep;
-    }
-

trunk/lib/jelix/controllers/jControllerDaoCrud.class.php

@@ -167 +167 @@
-        $tpl->assign('controls',$form->getControls());
-        $tpl->assign('editAction' , $this->_getAction('preupdate'));
-
+pre
-        $tpl->assign('deleteAction' , $this->_getAction('delete'));
-        $tpl->assign('viewAction' , $this->_getAction('view'));
@@ -190 +190 @@
-    protected function _index($resp, $tpl) {
-
+    }
+
+    /**
+     * prepare a form to create a record.
+     */
+    function precreate() {
+        // we cannot create the form directly in the create action
+        // because if the forms already exists, we wouldn't show
+        // errors or already filled field. see ticket #292
+        $form = jForms::create($this->form);
+        $rep = $this->getResponse('redirect');
+        $rep->action = $this->_getAction('create');
+        return $rep;
-    }
-