Changeset 866

Show
Ignore:
Timestamp:
04/07/08 00:40:05 (8 months ago)
Author:
laurentj
Message:

fixed bugs in jacl2

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/lib/jelix-scripts/commands/acl2group.cmd.php

    r864 r866  
    188188        $cnx = jDb::getConnection(jAclDb::getProfil()); 
    189189 
    190         $id = $this->_getGrpId($params[0]); 
     190        if($params[0] != 0) 
     191            $id = $this->_getGrpId($params[0]); 
    191192 
    192193        $sql="DELETE FROM jacl2_rights WHERE id_aclgrp="; 
     
    325326        $cnx = jDb::getConnection(jAclDb::getProfil()); 
    326327        if(is_numeric($param)){ 
     328            if(intval($param) >= 0) 
     329                die('Error: invalid group id'); 
    327330            $sql="SELECT id_aclgrp FROM jacl2_group WHERE grouptype <2 AND id_aclgrp = ".$param; 
    328331        }else{ 
  • trunk/lib/jelix-scripts/commands/acl2group.cmd.php

    r864 r866  
    188188        $cnx = jDb::getConnection(jAclDb::getProfil()); 
    189189 
    190         $id = $this->_getGrpId($params[0]); 
     190        if($params[0] != 0) 
     191            $id = $this->_getGrpId($params[0]); 
    191192 
    192193        $sql="DELETE FROM jacl2_rights WHERE id_aclgrp="; 
     
    325326        $cnx = jDb::getConnection(jAclDb::getProfil()); 
    326327        if(is_numeric($param)){ 
     328            if(intval($param) >= 0) 
     329                die('Error: invalid group id'); 
    327330            $sql="SELECT id_aclgrp FROM jacl2_group WHERE grouptype <2 AND id_aclgrp = ".$param; 
    328331        }else{ 
  • trunk/lib/jelix-scripts/commands/acl2group.cmd.php

    r864 r866  
    188188        $cnx = jDb::getConnection(jAclDb::getProfil()); 
    189189 
    190         $id = $this->_getGrpId($params[0]); 
     190        if($params[0] != 0) 
     191            $id = $this->_getGrpId($params[0]); 
    191192 
    192193        $sql="DELETE FROM jacl2_rights WHERE id_aclgrp="; 
     
    325326        $cnx = jDb::getConnection(jAclDb::getProfil()); 
    326327        if(is_numeric($param)){ 
     328            if(intval($param) >= 0) 
     329                die('Error: invalid group id'); 
    327330            $sql="SELECT id_aclgrp FROM jacl2_group WHERE grouptype <2 AND id_aclgrp = ".$param; 
    328331        }else{ 
  • trunk/lib/jelix-scripts/commands/acl2right.cmd.php

    r864 r866  
    7575 
    7676    protected function cmd_list(){ 
     77        echo "group\tsubject\t\tresource\n---------------------------------------------------------------\n"; 
     78        echo "- anonymous group\n"; 
     79        $sql="SELECT r.id_aclgrp, r.id_aclsbj, r.id_aclres, s.label_key as subject 
     80                FROM jacl2_rights r, jacl2_subject s 
     81                WHERE r.id_aclgrp = 0 AND r.id_aclsbj=s.id_aclsbj 
     82                ORDER BY subject, id_aclres "; 
     83        $cnx = jDb::getConnection(jAclDb::getProfil()); 
     84        $rs = $cnx->query($sql); 
     85        $sbj =-1; 
     86        foreach($rs as $rec){ 
     87            if($sbj !=$rec->id_aclsbj){ 
     88                $sbj = $rec->id_aclsbj; 
     89                echo "\t",$rec->id_aclsbj,"\n"; 
     90            } 
     91            echo "\t\t",$rec->id_aclres,"\n"; 
     92        } 
     93 
    7794        $sql="SELECT r.id_aclgrp, r.id_aclsbj, r.id_aclres, name as grp, s.label_key as subject 
    7895                FROM jacl2_rights r, jacl2_group g, jacl2_subject s 
     
    8198        $cnx = jDb::getConnection(jAclDb::getProfil()); 
    8299        $rs = $cnx->query($sql); 
    83         echo "group\tsubject\t\tresource\n---------------------------------------------------------------\n"; 
    84100        $grp=-1; 
    85101        $sbj =-1; 
     
    237253        $cnx = jDb::getConnection(jAclDb::getProfil()); 
    238254        if(is_numeric($param)){ 
     255            if($param == '0') 
     256                return 0; 
    239257            $sql="SELECT id_aclgrp FROM jacl2_group WHERE $c id_aclgrp = ".$param; 
    240258        }else{ 
     259            if($param =='anonymous') 
     260                return 0; 
    241261            $sql="SELECT id_aclgrp FROM jacl2_group WHERE $c name = ".$cnx->quote($param); 
    242262        } 
  • trunk/lib/jelix-scripts/commands/acl2right.cmd.php

    r864 r866  
    7575 
    7676    protected function cmd_list(){ 
     77        echo "group\tsubject\t\tresource\n---------------------------------------------------------------\n"; 
     78        echo "- anonymous group\n"; 
     79        $sql="SELECT r.id_aclgrp, r.id_aclsbj, r.id_aclres, s.label_key as subject 
     80                FROM jacl2_rights r, jacl2_subject s 
     81                WHERE r.id_aclgrp = 0 AND r.id_aclsbj=s.id_aclsbj 
     82                ORDER BY subject, id_aclres "; 
     83        $cnx = jDb::getConnection(jAclDb::getProfil()); 
     84        $rs = $cnx->query($sql); 
     85        $sbj =-1; 
     86        foreach($rs as $rec){ 
     87            if($sbj !=$rec->id_aclsbj){ 
     88                $sbj = $rec->id_aclsbj; 
     89                echo "\t",$rec->id_aclsbj,"\n"; 
     90            } 
     91            echo "\t\t",$rec->id_aclres,"\n"; 
     92        } 
     93 
    7794        $sql="SELECT r.id_aclgrp, r.id_aclsbj, r.id_aclres, name as grp, s.label_key as subject 
    7895                FROM jacl2_rights r, jacl2_group g, jacl2_subject s 
     
    8198        $cnx = jDb::getConnection(jAclDb::getProfil()); 
    8299        $rs = $cnx->query($sql); 
    83         echo "group\tsubject\t\tresource\n---------------------------------------------------------------\n"; 
    84100        $grp=-1; 
    85101        $sbj =-1; 
     
    237253        $cnx = jDb::getConnection(jAclDb::getProfil()); 
    238254        if(is_numeric($param)){ 
     255            if($param == '0') 
     256                return 0; 
    239257            $sql="SELECT id_aclgrp FROM jacl2_group WHERE $c id_aclgrp = ".$param; 
    240258        }else{ 
     259            if($param =='anonymous') 
     260                return 0; 
    241261            $sql="SELECT id_aclgrp FROM jacl2_group WHERE $c name = ".$cnx->quote($param); 
    242262        } 
  • trunk/lib/jelix-scripts/commands/acl2right.cmd.php

    r864 r866  
    7575 
    7676    protected function cmd_list(){ 
     77        echo "group\tsubject\t\tresource\n---------------------------------------------------------------\n"; 
     78        echo "- anonymous group\n"; 
     79        $sql="SELECT r.id_aclgrp, r.id_aclsbj, r.id_aclres, s.label_key as subject 
     80                FROM jacl2_rights r, jacl2_subject s 
     81                WHERE r.id_aclgrp = 0 AND r.id_aclsbj=s.id_aclsbj 
     82                ORDER BY subject, id_aclres "; 
     83        $cnx = jDb::getConnection(jAclDb::getProfil()); 
     84        $rs = $cnx->query($sql); 
     85        $sbj =-1; 
     86        foreach($rs as $rec){ 
     87            if($sbj !=$rec->id_aclsbj){ 
     88                $sbj = $rec->id_aclsbj; 
     89                echo "\t",$rec->id_aclsbj,"\n"; 
     90            } 
     91            echo "\t\t",$rec->id_aclres,"\n"; 
     92        } 
     93 
    7794        $sql="SELECT r.id_aclgrp, r.id_aclsbj, r.id_aclres, name as grp, s.label_key as subject 
    7895                FROM jacl2_rights r, jacl2_group g, jacl2_subject s 
     
    8198        $cnx = jDb::getConnection(jAclDb::getProfil()); 
    8299        $rs = $cnx->query($sql); 
    83         echo "group\tsubject\t\tresource\n---------------------------------------------------------------\n"; 
    84100        $grp=-1; 
    85101        $sbj =-1; 
     
    237253        $cnx = jDb::getConnection(jAclDb::getProfil()); 
    238254        if(is_numeric($param)){ 
     255            if($param == '0') 
     256                return 0; 
    239257            $sql="SELECT id_aclgrp FROM jacl2_group WHERE $c id_aclgrp = ".$param; 
    240258        }else{ 
     259            if($param =='anonymous') 
     260                return 0; 
    241261            $sql="SELECT id_aclgrp FROM jacl2_group WHERE $c name = ".$cnx->quote($param); 
    242262        } 
  • trunk/lib/jelix/plugins/coord/jacl2/jacl2.coord.php

    r864 r866  
    3636 
    3737        if(isset($params['jacl2.right'])) { 
    38             $aclok = jAcl::check($params['jacl2.right']); 
     38            $aclok = jAcl2::check($params['jacl2.right']); 
    3939 
    4040        }elseif(isset($params['jacl2.rights.and'])) { 
    4141            $aclok = true; 
    4242            foreach($params['jacl2.rights.and'] as $right) { 
    43                 if(!jAcl::check($right)) { 
     43                if(!jAcl2::check($right)) { 
    4444                    $aclok = false; 
    4545                    break; 
     
    4949            $aclok = false; 
    5050            foreach($params['jacl2.rights.or'] as $right) { 
    51                 if(jAcl::check($right)) { 
     51                if(jAcl2::check($right)) { 
    5252                    $aclok = true; 
    5353                    break; 
  • trunk/lib/jelix/plugins/coord/jacl2/jacl2.coord.php

    r864 r866  
    3636 
    3737        if(isset($params['jacl2.right'])) { 
    38             $aclok = jAcl::check($params['jacl2.right']); 
     38            $aclok = jAcl2::check($params['jacl2.right']); 
    3939 
    4040        }elseif(isset($params['jacl2.rights.and'])) { 
    4141            $aclok = true; 
    4242            foreach($params['jacl2.rights.and'] as $right) { 
    43                 if(!jAcl::check($right)) { 
     43                if(!jAcl2::check($right)) { 
    4444                    $aclok = false; 
    4545                    break; 
     
    4949            $aclok = false; 
    5050            foreach($params['jacl2.rights.or'] as $right) { 
    51                 if(jAcl::check($right)) { 
     51                if(jAcl2::check($right)) { 
    5252                    $aclok = true; 
    5353                    break; 
  • trunk/lib/jelix/plugins/coord/jacl2/jacl2.coord.php

    r864 r866  
    3636 
    3737        if(isset($params['jacl2.right'])) { 
    38             $aclok = jAcl::check($params['jacl2.right']); 
     38            $aclok = jAcl2::check($params['jacl2.right']); 
    3939 
    4040        }elseif(isset($params['jacl2.rights.and'])) { 
    4141            $aclok = true; 
    4242            foreach($params['jacl2.rights.and'] as $right) { 
    43                 if(!jAcl::check($right)) { 
     43                if(!jAcl2::check($right)) { 
    4444                    $aclok = false; 
    4545                    break; 
     
    4949            $aclok = false; 
    5050            foreach($params['jacl2.rights.or'] as $right) { 
    51                 if(jAcl::check($right)) { 
     51                if(jAcl2::check($right)) { 
    5252                    $aclok = true; 
    5353                    break; 
  • trunk/testapp/modules/jelix_tests/tests/jacl2.main_api.html_cli.php

    r864 r866  
    9595        $this->assertFalse(jAcl2::check('super.cms.list')); 
    9696        $this->assertFalse(jAcl2::check('admin.access')); 
     97        jAcl2::clearCache(); 
     98        jAcl2DbManager::addRight(0, 'super.cms.list' ); 
     99        $this->assertTrue(jAcl2::check('super.cms.list')); 
     100        $this->assertFalse(jAcl2::check('admin.access')); 
    97101        jAuth::$connect = true; 
    98102        jAcl2::clearCache(); 
  • trunk/testapp/modules/jelix_tests/tests/jacl2.main_api.html_cli.php

    r864 r866  
    9595        $this->assertFalse(jAcl2::check('super.cms.list')); 
    9696        $this->assertFalse(jAcl2::check('admin.access')); 
     97        jAcl2::clearCache(); 
     98        jAcl2DbManager::addRight(0, 'super.cms.list' ); 
     99        $this->assertTrue(jAcl2::check('super.cms.list')); 
     100        $this->assertFalse(jAcl2::check('admin.access')); 
    97101        jAuth::$connect = true; 
    98102        jAcl2::clearCache(); 
  • trunk/testapp/modules/jelix_tests/tests/jacl2.main_api.html_cli.php

    r864 r866  
    9595        $this->assertFalse(jAcl2::check('super.cms.list')); 
    9696        $this->assertFalse(jAcl2::check('admin.access')); 
     97        jAcl2::clearCache(); 
     98        jAcl2DbManager::addRight(0, 'super.cms.list' ); 
     99        $this->assertTrue(jAcl2::check('super.cms.list')); 
     100        $this->assertFalse(jAcl2::check('admin.access')); 
    97101        jAuth::$connect = true; 
    98102        jAcl2::clearCache(); 
Download in other formats: Unified Diff Zip Archive