Changeset 976

Show
Ignore:
Timestamp:
06/04/08 23:43:50 (6 months ago)
Author:
laurentj
Message:

performance improvement: the check of the temp dir is now made when creating the cache of the ini file

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/lib/jelix/core/jConfigCompiler.class.php

    r937 r976  
    3030    static public function read($configFile){ 
    3131 
     32        if(JELIX_APP_TEMP_PATH=='/'){ 
     33            // if it equals to '/', this is because realpath has returned false in the application.init.php 
     34            // so this is because the path doesn't exist. 
     35            die('Jelix Error: Application temp directory doesn\'t exist !'); 
     36        } 
     37 
     38        if(!is_writable(JELIX_APP_TEMP_PATH)){ 
     39            die('Jelix Error: Application temp directory is not writable'); 
     40        } 
     41 
    3242#if ENABLE_PHP_JELIX 
    3343        $config = jelix_read_ini(JELIX_LIB_CORE_PATH.'defaultconfig.ini.php'); 
    3444 
    35         @jelix_read_ini(JELIX_APP_CONFIG_PATH.'defaultconfig.ini.php',$config); 
     45        @jelix_read_ini(JELIX_APP_CONFIG_PATH.'defaultconfig.ini.php', $config); 
    3646 
    3747        if($configFile !='defaultconfig.ini.php'){ 
    3848            if(!file_exists(JELIX_APP_CONFIG_PATH.$configFile)) 
    3949                die("Jelix config file $configFile is missing !"); 
    40             if( false === @jelix_read_ini(JELIX_APP_CONFIG_PATH.$configFile,$config)) 
     50            if( false === @jelix_read_ini(JELIX_APP_CONFIG_PATH.$configFile, $config)) 
    4151                die("Syntax error in the Jelix config file $configFile !"); 
    4252        } 
    43         $config->isWindows = (DIRECTORY_SEPARATOR == '\\'); 
     53 
     54        $config->isWindows = (DIRECTORY_SEPARATOR === '\\'); 
    4455        if(trim( $config->startAction) == '') { 
    4556            $config->startAction = ':'; 
  • trunk/lib/jelix/core/jConfigCompiler.class.php

    r937 r976  
    3030    static public function read($configFile){ 
    3131 
     32        if(JELIX_APP_TEMP_PATH=='/'){ 
     33            // if it equals to '/', this is because realpath has returned false in the application.init.php 
     34            // so this is because the path doesn't exist. 
     35            die('Jelix Error: Application temp directory doesn\'t exist !'); 
     36        } 
     37 
     38        if(!is_writable(JELIX_APP_TEMP_PATH)){ 
     39            die('Jelix Error: Application temp directory is not writable'); 
     40        } 
     41 
    3242#if ENABLE_PHP_JELIX 
    3343        $config = jelix_read_ini(JELIX_LIB_CORE_PATH.'defaultconfig.ini.php'); 
    3444 
    35         @jelix_read_ini(JELIX_APP_CONFIG_PATH.'defaultconfig.ini.php',$config); 
     45        @jelix_read_ini(JELIX_APP_CONFIG_PATH.'defaultconfig.ini.php', $config); 
    3646 
    3747        if($configFile !='defaultconfig.ini.php'){ 
    3848            if(!file_exists(JELIX_APP_CONFIG_PATH.$configFile)) 
    3949                die("Jelix config file $configFile is missing !"); 
    40             if( false === @jelix_read_ini(JELIX_APP_CONFIG_PATH.$configFile,$config)) 
     50            if( false === @jelix_read_ini(JELIX_APP_CONFIG_PATH.$configFile, $config)) 
    4151                die("Syntax error in the Jelix config file $configFile !"); 
    4252        } 
    43         $config->isWindows = (DIRECTORY_SEPARATOR == '\\'); 
     53 
     54        $config->isWindows = (DIRECTORY_SEPARATOR === '\\'); 
    4455        if(trim( $config->startAction) == '') { 
    4556            $config->startAction = ':'; 
  • trunk/lib/jelix/core/jConfigCompiler.class.php

    r937 r976  
    3030    static public function read($configFile){ 
    3131 
     32        if(JELIX_APP_TEMP_PATH=='/'){ 
     33            // if it equals to '/', this is because realpath has returned false in the application.init.php 
     34            // so this is because the path doesn't exist. 
     35            die('Jelix Error: Application temp directory doesn\'t exist !'); 
     36        } 
     37 
     38        if(!is_writable(JELIX_APP_TEMP_PATH)){ 
     39            die('Jelix Error: Application temp directory is not writable'); 
     40        } 
     41 
    3242#if ENABLE_PHP_JELIX 
    3343        $config = jelix_read_ini(JELIX_LIB_CORE_PATH.'defaultconfig.ini.php'); 
    3444 
    35         @jelix_read_ini(JELIX_APP_CONFIG_PATH.'defaultconfig.ini.php',$config); 
     45        @jelix_read_ini(JELIX_APP_CONFIG_PATH.'defaultconfig.ini.php', $config); 
    3646 
    3747        if($configFile !='defaultconfig.ini.php'){ 
    3848            if(!file_exists(JELIX_APP_CONFIG_PATH.$configFile)) 
    3949                die("Jelix config file $configFile is missing !"); 
    40             if( false === @jelix_read_ini(JELIX_APP_CONFIG_PATH.$configFile,$config)) 
     50            if( false === @jelix_read_ini(JELIX_APP_CONFIG_PATH.$configFile, $config)) 
    4151                die("Syntax error in the Jelix config file $configFile !"); 
    4252        } 
    43         $config->isWindows = (DIRECTORY_SEPARATOR == '\\'); 
     53 
     54        $config->isWindows = (DIRECTORY_SEPARATOR === '\\'); 
    4455        if(trim( $config->startAction) == '') { 
    4556            $config->startAction = ':'; 
  • trunk/lib/jelix/core/jConfigCompiler.class.php

    r937 r976  
    3030    static public function read($configFile){ 
    3131 
     32        if(JELIX_APP_TEMP_PATH=='/'){ 
     33            // if it equals to '/', this is because realpath has returned false in the application.init.php 
     34            // so this is because the path doesn't exist. 
     35            die('Jelix Error: Application temp directory doesn\'t exist !'); 
     36        } 
     37 
     38        if(!is_writable(JELIX_APP_TEMP_PATH)){ 
     39            die('Jelix Error: Application temp directory is not writable'); 
     40        } 
     41 
    3242#if ENABLE_PHP_JELIX 
    3343        $config = jelix_read_ini(JELIX_LIB_CORE_PATH.'defaultconfig.ini.php'); 
    3444 
    35         @jelix_read_ini(JELIX_APP_CONFIG_PATH.'defaultconfig.ini.php',$config); 
     45        @jelix_read_ini(JELIX_APP_CONFIG_PATH.'defaultconfig.ini.php', $config); 
    3646 
    3747        if($configFile !='defaultconfig.ini.php'){ 
    3848            if(!file_exists(JELIX_APP_CONFIG_PATH.$configFile)) 
    3949                die("Jelix config file $configFile is missing !"); 
    40             if( false === @jelix_read_ini(JELIX_APP_CONFIG_PATH.$configFile,$config)) 
     50            if( false === @jelix_read_ini(JELIX_APP_CONFIG_PATH.$configFile, $config)) 
    4151                die("Syntax error in the Jelix config file $configFile !"); 
    4252        } 
    43         $config->isWindows = (DIRECTORY_SEPARATOR == '\\'); 
     53 
     54        $config->isWindows = (DIRECTORY_SEPARATOR === '\\'); 
    4455        if(trim( $config->startAction) == '') { 
    4556            $config->startAction = ':'; 
  • trunk/lib/jelix/core/jCoordinator.class.php

    r845 r976  
    8080        $gJCoord =  $this; 
    8181 
    82         if(JELIX_APP_TEMP_PATH=='/'){ // le realpath dans application.ini.php a renvoyé false... 
    83             die('Jelix Error: Application temp directory doesn\'t exist !'); 
    84         } 
    85         if(!is_writable(JELIX_APP_TEMP_PATH)){ 
    86             die('Jelix Error: Application temp directory is not writable'); 
    87         } 
    8882        // load configuration data 
    8983        $gJConfig = jConfig::load($configFile); 
  • trunk/lib/jelix/core/jCoordinator.class.php

    r845 r976  
    8080        $gJCoord =  $this; 
    8181 
    82         if(JELIX_APP_TEMP_PATH=='/'){ // le realpath dans application.ini.php a renvoyé false... 
    83             die('Jelix Error: Application temp directory doesn\'t exist !'); 
    84         } 
    85         if(!is_writable(JELIX_APP_TEMP_PATH)){ 
    86             die('Jelix Error: Application temp directory is not writable'); 
    87         } 
    8882        // load configuration data 
    8983        $gJConfig = jConfig::load($configFile); 
  • trunk/lib/jelix/core/jCoordinator.class.php

    r845 r976  
    8080        $gJCoord =  $this; 
    8181 
    82         if(JELIX_APP_TEMP_PATH=='/'){ // le realpath dans application.ini.php a renvoyé false... 
    83             die('Jelix Error: Application temp directory doesn\'t exist !'); 
    84         } 
    85         if(!is_writable(JELIX_APP_TEMP_PATH)){ 
    86             die('Jelix Error: Application temp directory is not writable'); 
    87         } 
    8882        // load configuration data 
    8983        $gJConfig = jConfig::load($configFile); 
  • trunk/lib/jelix/core/jCoordinator.class.php

    r845 r976  
    8080        $gJCoord =  $this; 
    8181 
    82         if(JELIX_APP_TEMP_PATH=='/'){ // le realpath dans application.ini.php a renvoyé false... 
    83             die('Jelix Error: Application temp directory doesn\'t exist !'); 
    84         } 
    85         if(!is_writable(JELIX_APP_TEMP_PATH)){ 
    86             die('Jelix Error: Application temp directory is not writable'); 
    87         } 
    8882        // load configuration data 
    8983        $gJConfig = jConfig::load($configFile); 
Download in other formats: Unified Diff Zip Archive