zone tpl plugin does not work with meta tpl plugins of a cached zone template

[bricet]

As for #1196 , the {zone} plugin for templates does not take into account metas of a zone which have a _templatename set. This occurs when this zone is cached. This is a cascading situation, but this may happen ...

Here is a patch.

[laurentj]

sorry, too late for 1.2

[laurentj]

There isn't any method getMeta on jZone... And I think the issue is not on the zone publing but on jZone directly.

No time to investigate for the moment.

[bricet]

Replying to laurentj:

There isn't any method getMeta on jZone... And I think the issue is not on the zone publing but on jZone directly.

Sorry I forgot a piece of the patch ...

No time to investigate for the moment.

You're right. This patch is dumb as metas are included twice at least in most cases. I will think again about this problem. Actually I think I've gone throught it too fast and did not notice exactly in which cases the bug occurs ... if there is a bug (big doubt, now).

Sorry for the inconvenience ...

[bricet]

After thinking a bit about it and before forgetting :

I can see at least one case in which there is a bug :

Let's have 2 zones : zA and zB.

zA has :

protected $_tplname='tA';
protected $_useCache = true ;

zB has :

protected $_tplname='tB';

In tA, we have :

{zone 'zB'}

And in tB :

{meta author 'jelix'}

This meta will be used only on first load (i.e. when zA 's cache is built). But on next loads, it won't be used. This is because zA 's content has been cached but not metas (because of the way metas are handled in a different way than content by jTpl).

To me, a way to solve that, would be that {zone} jTpl plugin does not call jZone::get() but :

• set a 'jZone::getMeta()' in $compiler->addMetaContent (I have already something like that)
• returns 'jZone::getContentOnly()' (i.e. something that does the same as jZone::get() but does not handle metas of $_tplname

I will try to make a patch as soon as I have time. Just wanted to write those ideas before forgetting ...

[laurentj]

No news ?

[bricet]

I finally solved the bug with  https://github.com/jelix/jelix/pull/92 and it was accepted strait forward ... I just can not believe it ! ;) I think we can now set this ticket as fixed, now ...