Ticket #560 (closed enhancement: fixed)

Opened 7 months ago

Last modified 5 months ago

Redimension d'image avec hauteur et largeur max

Reported by: Lipki Assigned to:
Priority: normal Milestone: Jelix 1.0.4
Component: jelix:plugins Version: 1.0.3
Severity: normal Keywords:
Cc: Php version:
Review: Hosting Provider:
Documentation needed: 0 Blocking:

Description

A la demande général de bast.

Voici une nouvelle option du plugin image qui permet de définir une largeur et hauteur maximum. Option utilisée souvent dans les galeries d'images.

Attachments

image_proportion.diff (2.4 kB) - added by Lipki on 04/24/08 00:39:36.
jelix-trunk-#560.patch (11.2 kB) - added by bibo on 06/23/08 12:27:34.
keep aspectratio patch

Change History

04/24/08 00:39:36 changed by Lipki

  • attachment image_proportion.diff added.

04/24/08 09:46:19 changed by laurentj

  • review changed from review? to review+.

It's ok to land it into branch 1.0.x & trunk.

04/24/08 09:48:04 changed by laurentj

  • type changed from bug to enhancement.
  • milestone set to Jelix 1.0.4.

04/24/08 10:24:34 changed by bastnic

  • status changed from new to closed.
  • resolution set to fixed.

commited ! (thanks Lipki ;))

06/23/08 12:19:31 changed by bibo

  • status changed from closed to reopened.
  • review deleted.
  • resolution deleted.

I reopen this bug as it does not keep aspectratio of image and i think it should. Take a 360x480 image size and specify maxwidth=800 and maxheight=600 and you'll get a 800x800 result.

Moreover, I think also it shoud NOT force a resize if the image is smaller than the values attributed to maxwidth and maxheight. As it is a more common case to prevent stretching imho.

06/23/08 12:27:34 changed by bibo

  • attachment jelix-trunk-#560.patch added.

keep aspectratio patch

06/23/08 12:39:57 changed by bibo

  • review set to review?.

06/23/08 13:25:23 changed by laurentj

  • status changed from reopened to closed.
  • component changed from jelix to jelix:plugins.
  • review deleted.
  • resolution set to fixed.

it does not keep aspectratio of image and i think it should.

So it is a bug : create a new ticket, don't reopen this ticket

06/23/08 14:39:48 changed by bibo

sorry for spam, I created ticket http://developer.jelix.org/ticket/628

Download in other formats: Comma-delimited Text Tab-delimited Text RSS Feed