Ticket #628 (closed bug: fixed)

Opened 2 months ago

Last modified 1 month ago

preserve aspectratio with maxwidth and maxheight attributes (plugin image)

Reported by: bibo Assigned to: bibo
Priority: normal Milestone: Jelix 1.0.5
Component: jelix:plugins Version: 1.0.4
Severity: normal Keywords:
Cc: Php version:
Review: review+ Hosting Provider:
Documentation needed: 0 Blocking:

Description

plugin image does not preserve aspectratio of image with maxwidth and maxheight attributes and i think it should. Take a 360x480 image size and specify maxwidth=800 and maxheight=600 and you'll get a 800x800 result.

Moreover, I think also it shoud NOT force a resize if the image is smaller than the values attributed to maxwidth and maxheight. As it is a more common case to prevent stretching imho.

Attachments

jelix-trunk-#628.patch (11.2 kB) - added by bibo on 06/23/08 14:26:18.

Change History

06/23/08 14:26:18 changed by bibo

  • attachment jelix-trunk-#628.patch added.

06/23/08 14:27:12 changed by bibo

  • review set to review?.

06/23/08 14:32:11 changed by bibo

the latest patch is trunk only. I could make another one for 1.0.4 but after review.

07/11/08 16:18:45 changed by laurentj

  • review changed from review? to review+.
  • version changed from trunk to 1.0.4.
  • milestone set to Jelix 1.0.5.

ok

07/12/08 09:50:44 changed by bibo

Checked in the patch to trunk. Still have to land this on 1.0.5 branch...

07/18/08 23:04:42 changed by laurentj

  • status changed from new to closed.
  • resolution set to fixed.

The version of 1.0.x branch didn't contains previous bug fixes. I updated then this version with your patch and this other bug fixes.

Download in other formats: Comma-delimited Text Tab-delimited Text RSS Feed