pagelinks plugin uses offsets instead of page numbers

[Surfoo]

Currently, pagelinks uses offsets but page numbers would be better for everyone, it's more understandable !

[Surfoo]

So this is my patch for fix it and i changed labels too, it's less ugly, isn't it ?

[laurentj]

The problem of your patch is that you break all existing use of this plugin, isn't it ?

Why did you replace "," by "." in all echo instructions ? It is better to use a ",", because there isn't a concatenation...

[bballizlife]

We're facing a little problem here as your path break compatibility with existing uses, as said by laurentj. On the other hand, i agree that using pages instead of offset is a better way. As of now, i don't know how to deal with this issue. Maybe a "pagelinkspages" plugin ?

At last, i don't mind about the "s/,/."

[bballizlife]

Well, i thought about this issue.

- Do we want a "pagelinks" plugin that works with pages instead of offset ? I'd like to.

- Can we break compatibility ? I think we cannot as this will force to much code changes for the users (computing pages numbers, modifying their URLs settings, ...)

- Can we add the "pages feature" and keep compatibility ? This will need to modify the prototype of the function. Not impossible but i think such a way will add to much complexity to the function. It already has 7 parameters, that's enough. We need to think about the ease of use for developers

- So what can we do ? My conclusion is that the simplest way is to code another plugin we could name : "pagelinks_pages" for example.

The only thing we must take care about is both "pagelinks" plugin should generate the same html (tags and attributes).

What about you ?

[laurentj]

I propose to replace the $paramName parameter by an array of options. allowed values in this array are:

  'paramName'=>'offset',
  'behavior'=>'page' or 'offset'

If you find a better name for 'behavior'...

The plugin should check the type of this parameter. If this is a string, 'paramName'=> the value of the parameter, and 'behavior'=>'offset'. If this is an array, try to get 'paramName' and 'behavior' from into it. If the 'behavior' key in this array is missing, default value is 'page'.

[bballizlife]

Nice idea. I agree with it.

@Surfoo : could you update your patch with what laurentj said ?

[Surfoo]

Désolé je la fait en français là..

J'ai dupliqué le code au lieu de faire des hack partout pour savoir si c'était un comportement d'offset ou de page qui était utilisé. Surtout que c'est toujours des petites modifications (genre un caractère à changer) et avoir le meme style de hack partout, bof.. Qu'est ce que vous en pensez comme ça ?

J'ai aussi supprimé le dernier else en bas du code, ça sert à rien d'avoir une pagination d'une seule page et qui ne soit pas cliquable (et j'ai rajouté un return false pour vérifier ça plus haut).

[bballizlife]

Not to display pagination if there's only 1 page is ok for me. So as for separating behaviours. It's more readable i think too.

But as unit tests fail, i can't accept the patch for now. I don't think it's a huge tasks so please take care at the UT. Thanks.

Then we should be ok with that patch.

[laurentj]

because of fails of unit tests