Ticket #932 (closed bug: fixed)

Opened 16 months ago

Last modified 12 months ago

enhancement in jMailer file driver

Reported by: bastnic Owned by: bastnic
Priority: normal Milestone: Jelix 1.2 beta
Component: jelix:utils Version: trunk
Severity: normal Keywords:
Cc: Php version:
Review: review- Hosting Provider:
Blocked By: Documentation needed: no
Blocking:

Description

Laurent recently add a file driver for jMailer which I think it's a very great idea during dev.

But if more than one mail is sent in the same second, only one file is generated. So I add a little random pattern. I used jAuth::getRandomPassword which I don't think it's a good idea for jelix core.

Furthermore, I add a little return to line between header and body

Attachments

patch-jmailer.diff (1.0 kB) - added by bastnic 16 months ago.

Change History

Changed 16 months ago by bastnic

Changed 16 months ago by bastnic

  • review set to review?

Changed 16 months ago by laurentj

  • review changed from review? to review-

This dependency with jAuth is not good.

Changed 16 months ago by Julien

you may use

$token = uniqid(mt_rand(), true);

there are still collision risks if mt_rand() returns the same value and both intructions are called in the same microsecond, but that's quite improbable.

Changed 14 months ago by bastnic

  • owner set to bastnic
  • status changed from new to assigned
  • milestone set to Jelix 1.2

Changed 12 months ago by laurentj

  • status changed from assigned to closed
  • resolution set to fixed

Fixed the issue in changeset http://hg.jelix.org/jelix/jelix-trunk/rev/319c81b9a1ec

thanks Bastnic and Julien.

Note: See TracTickets for help on using tickets.