developer.jelix.org n'est plus utilisée, et existe uniquement pour son historique. Postez les nouveaux tickets sur le compte github.
Opened 11 years ago
Closed 11 years ago
#1151 closed bug (fixed)
jForms: when (de)activating a choice control, subelements should be marked as disabled instead of readonly
| Reported by: | Julien | Owned by: | Julien |
|---|---|---|---|
| Priority: | normal | Milestone: | Jelix 1.2RC1 |
| Component: | jelix:forms | Version: | trunk |
| Severity: | normal | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Documentation needed: | no | |
| Hosting Provider: | Php version: |
Description
Attachments (1)
Change History (8)
comment:1 Changed 11 years ago by Julien
- review set to review?
- Status changed from new to assigned
comment:2 follow-up: ↓ 3 Changed 11 years ago by laurentj
- review changed from review? to review-
why? what is the problem ?
However, the patch is not enough. Builders should generate also disabled attribute.
comment:3 in reply to: ↑ 2 Changed 11 years ago by Julien
Replying to laurentj:
why? what is the problem ?
I just think that marking the non-usable fields as disabled is better as marking them as readonly (still applicable but not updatable). I think it gives more sense. Kind of "semantic" thing :)
However, the patch is not enough. Builders should generate also disabled attribute.
ok you're right, I should have modified the builders too... If you're ok with the fact that "disabled" is better than "readonly", I'll complete the patch.
thanks for your answer Laurent
comment:4 Changed 11 years ago by laurentj
I think there is a reason why I set readonly instead of disabled. But I don't remember....
comment:5 Changed 11 years ago by Julien
In current testapp (testapp/www/index.php?module=testapp&action=sampleform:newform) we can see that readonly attribute is not good as at the bottom of the form, the "Closed Status" menulist can still be changed.
New mq patch is coming (modified builders too)
comment:6 Changed 11 years ago by Julien
- review changed from review- to review?
here it is: http://bitbucket.org/julieni/jelix-trunk-patches/changeset/97e060d32aa7
I also made other improvements, so the patch is quite big, but most the changes are related to the initial problem
comment:7 Changed 11 years ago by laurentj
- Resolution set to fixed
- review changed from review? to review+
- Status changed from assigned to closed
checked in http://bitbucket.org/jelix/jelix-trunk/changeset/d035f747cc64. Thanks for the patch.
see http://bitbucket.org/julieni/jelix-trunk/changeset/dcbf0c31549a