developer.jelix.org n'est plus utilisée, et existe uniquement pour son historique. Postez les nouveaux tickets sur le compte github.
Opened 10 years ago
Closed 10 years ago
#1188 closed bug (fixed)
<link> tags in <head> do not always have a type
| Reported by: | bricet | Owned by: | laurentj |
|---|---|---|---|
| Priority: | normal | Milestone: | Jelix 1.1.7 |
| Component: | jelix:core response | Version: | trunk |
| Severity: | normal | Keywords: | |
| Cc: | dominique.papin@… | Blocked By: | |
| Blocking: | Documentation needed: | no | |
| Hosting Provider: | Php version: |
Description
After looking at ticket #841, comments told that addLink should be used instead of making a patch to build canonical <link> tags.
But according to http://www.google.com/support/webmasters/bin/answer.py?hl=en&answer=139394 for example, there is no type for that <link> tag. So I just want to make the type optionnal, which is not the case right now.
I include a patch
Attachments (2)
Change History (8)
Changed 10 years ago by bricet
comment:1 Changed 10 years ago by bricet
- review set to review?
comment:2 Changed 10 years ago by bibo
- Cc dominique.papin@… added
- review changed from review? to review+
comment:3 follow-up: ↓ 4 Changed 10 years ago by laurentj
Why $params[0] becomes $params[1] in the line of "echo" ? It should be $params[0] imho.
comment:4 in reply to: ↑ 3 Changed 10 years ago by bricet
Replying to laurentj:
Why $params[0] becomes $params[1] in the line of "echo" ? It should be $params[0] imho.
Good point. Sorry for the mistake.
New patch included (and I suppose that previous patch was really dirty, though : this one should merge fine).
Changed 10 years ago by bricet
comment:5 Changed 10 years ago by laurentj
- Milestone set to Jelix 1.2
comment:6 Changed 10 years ago by laurentj
- Milestone changed from Jelix 1.2 to Jelix 1.1.7
- Resolution set to fixed
- Status changed from new to closed
marking as review+.
This should be backported to 1.1.X