developer.jelix.org is not used any more and exists only for history. Post new tickets on the Github account.
developer.jelix.org n'est plus utilisée, et existe uniquement pour son historique. Postez les nouveaux tickets sur le compte github.

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#1191 closed bug (invalid)

jUnitTestCaseDb don't take table_prefix into account

Reported by: catsoup Owned by:
Priority: normal Milestone: Jelix 1.2RC1
Component: module:junittests Version: trunk
Severity: normal Keywords:
Cc: Blocked By:
Blocking: Documentation needed: no
Hosting Provider: Php version:

Description

We must add prefixTable() to the class jUnitTestCaseDb of the module junittests for trunk and 1.1.x

Change History (3)

comment:1 Changed 9 years ago by catsoup

  • review set to review?

I'm really not sure about this, so didn't done the patch for 1.1.x yet The patch for trunk is here: https://bitbucket.org/catsoup/jelix-trunk-patches/src/tip/ticket1191.patch

I'm not sure because I wonder if prefixTable should be called in jUnitTestCaseDb itself or in the tests.

For example, the only tests calling jUnitTestCaseDb functions, in testapp are in jacl.manager : https://bitbucket.org/jelix/jelix-trunk/src/tip/testapp/modules/jelix_tests/tests/jacl.manager.html_cli.php

My goal was to make testapp tests pass, so I made 2 others patch for testapp, you can watch them here: https://bitbucket.org/catsoup/jelix-trunk-patches/src/tip/testapp-sql-prefix.patch
https://bitbucket.org/catsoup/jelix-trunk-patches/src/tip/testapp-testsfails-with-table_prefix-bugfix.patch

To make all testapp tests pass, we also need to create sql install file for sqlite, as it seems that the file tests.sqlite has been created by another way, and also test others databases (I expect to test postgresql)
Should I make a new ticket for testapp tests fails ?

comment:2 Changed 9 years ago by catsoup

  • Resolution set to invalid
  • review review? deleted
  • Status changed from new to closed

oops, sorry, I didn't see your answer on #1190. Ok, It made me a good training :p

comment:3 Changed 9 years ago by catsoup

I set this ticket invalid, because after a lot of reflection (:p), prefixTable must be set in the tests, not in jUnitTestCaseDb.

Note: See TracTickets for help on using tickets.