developer.jelix.org is not used any more and exists only for history. Post new tickets on the Github account.
developer.jelix.org n'est plus utilisée, et existe uniquement pour son historique. Postez les nouveaux tickets sur le compte github.

Opened 10 years ago

Closed 8 years ago

#1212 closed bug (worksforme)

jMailer: jTpl meta names should all use the same case

Reported by: Julien Owned by: Julien
Priority: high Milestone:
Component: jelix:utils Version: trunk
Severity: major Keywords:
Cc: Blocked By:
Blocking: Documentation needed: no
Hosting Provider: Php version:

Description

when using meta from a template, we can use keywords as: From, Subject, ReplyTo?, ...

we also added: to, cc, bcc

I think all of them should be written with the same case, so I suggest renaming the following way:

to -> To cc -> CC bcc-> BCC

so we match phpMailer's names for properties/methods

Change History (6)

comment:1 Changed 10 years ago by Julien

  • review set to review?
  • Status changed from new to assigned

comment:2 Changed 10 years ago by laurentj

  • Milestone Jelix 1.2RC2 deleted
  • Resolution set to wontfix
  • review changed from review? to review-
  • Status changed from assigned to closed

so we match phpMailer's names for properties/methods

the current properties in phpMailer are cc, bcc, to, not CC, BCC or To. This is why I retrieve cc, bcc and to.

And if we change this, we break existing templates..

comment:3 Changed 10 years ago by Julien

  • Resolution wontfix deleted
  • Status changed from closed to reopened

Ok, theses properties (to, cc) are protected, so I based my reflexion on methods name : AddCC, AddBCC, ...

I thought we could break a little compatibility with jelix 1.2, because for me it's still strange to write :

{meta Subject 'Super mail.'}
{meta Priority 1}
{meta From 'votre nom<votre@mail.com>'}
{meta Sender 'votre@mail.com'}
{meta ReplyTo array('votre nom<votre@mail.com>')}
{meta to array('votre nom<votre@mail.com>')}

to, cc and bcc will be the only ones that don't use camelCase (as phpMailer does)

but ok if we explain this in the doc

another thing we should say in the doc is that these meta produce tpl vars, so any var named 'From', 'Sender', 'to', 'bcc' assigned from controller, .... will be overwritten when parsing meta.

But this might be another ticket ?

Re-opening ticket for your answer, just close it if you don't want to change anything.

comment:4 Changed 10 years ago by laurentj

  • Documentation needed set

ok. we should indicate it in the documentation.

comment:6 Changed 8 years ago by laurentj

  • Resolution set to worksforme
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.