developer.jelix.org n'est plus utilisée, et existe uniquement pour son historique. Postez les nouveaux tickets sur le compte github.
Opened 10 years ago
Closed 10 years ago
#1394 closed bug (fixed)
Php5Redis seems not to be working fine anymore (testapp proof)
Reported by: | bricet | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | Jelix 1.3 |
Component: | jelix:kvdb | Version: | 1.2.2 |
Severity: | normal | Keywords: | redis set increment decrement |
Cc: | Blocked By: | ||
Blocking: | Documentation needed: | no | |
Hosting Provider: | Php version: |
Description
I am running Redis 2.2.10 and testapp output some errors :
- some of them are due to the way php5redis handles SET and SETNX. I suppose using Redis protocol ( http://redis.io/topics/protocol ) is the best way to solve this trouble. May be this should be generalized to all commands. May be we should consider using another connector to Redis than Php5Redis
- some of them are due to increment and decrement using float (increment/decrement a float with an int, increment/decrement an int with a float). I don't know what is the exact purpose of those tests, but it seems to me to be a side-effect test. In this particular test, Redis can not handle that
Change History (7)
comment:1 Changed 10 years ago by bricet
comment:2 Changed 10 years ago by bricet
- review set to review?
comment:3 Changed 10 years ago by laurentj
- review review? deleted
Sorry, I don't know Redis protocol, and don't have time to deep inside it. Propose your patch upstream first ( https://github.com/sash/php-redis ).
Replacing Php5redis why not. But other libs I see here http://redis.io/clients seems to be bloatwares (predis or rediska, no I don't want to integrate Zend framework in jelix), or not enough developped.
NB: documentation on how to propose a patch http://developer.jelix.org/wiki/fr/patchs
comment:4 Changed 10 years ago by laurentj
notice that php5redis is compatible officialy with Redis 1.2, not 2.2.
comment:5 Changed 10 years ago by laurentj
There is a newer version of php5redis. It seems it has a better support of the new protocol in 2.2 and does almost same thing as your patch. I updated it on the trunk.
However errors are still there.
comment:6 Changed 10 years ago by laurentj
- Milestone set to Jelix 1.3
comment:7 Changed 10 years ago by laurentj
- Resolution set to fixed
- Status changed from new to closed
I don't know how to handle hg fine for now, but I have a way to solve first point :
hg pull -r 4a216a8450a7 https://bitbucket.org/bricet/jelix-trunk
Second point still needs some big chief's point of view ...