url_significant plugin, force https and http

[zitoun]

While jurl can generate https urls with specific parameter in urls.xml, it cannot force to http other actions. I suggest to turn around this limitation by using the parameter in a 3-state value:

• https="true" => force jurl to generate a full https url
• http="false" => force jurl to generate a full http url
• no parameter (=null) => common use, generate relative urls

List of files updated to support the patch:

• jelix/plugins/urls/significant/jSignificantUrlsCompiler.class.php

method compile():

$this->defaultUrl = new significantUrlInfoParsing (
                $type,
                (string)$tag['name'],
                (isset($tag['default']) ? (((string)$tag['default']) == 'true'):false),
                (isset($tag['https']) ? (((string)$tag['https']) == 'true'):null)
            );

• jelix/plugins/urls/significant/significants.urls.php

method create():

        if ($urlinfo[2])
            $url->scriptName = $GLOBALS['gJCoord']->request->getServerURI(true).$url->scriptName;
	else if ($urlinfo[2] === false)
	    $url->scriptName = $GLOBALS['gJCoord']->request->getServerURI(false).$url->scriptName;
}}

[zitoun]

1/ jelix/plugins/urls/significant/jSignificantUrlsCompiler.class.php method compile():

$this->defaultUrl = new significantUrlInfoParsing (
                $type,
                (string)$tag['name'],
                (isset($tag['default']) ? (((string)$tag['default']) == 'true'):false),
                (isset($tag['https']) ? (((string)$tag['https']) == 'true'):null)
            );

2/ jelix/plugins/urls/significant/significants.urls.php method create():

if ($urlinfo[2])
            $url->scriptName = $GLOBALS['gJCoord']->request->getServerURI(true).$url->scriptName;
	else if ($urlinfo[2] === false)
	    $url->scriptName = $GLOBALS['gJCoord']->request->getServerURI(false).$url->scriptName;

[zitoun]

This patch cause response type sitemap to provide wrong full urls. Change on the file jResponseSitemap.class.php:

method addUrl():

		if (preg_match('/^http/', $loc)) {
			$url->loc = $loc;
		}
		else {
			$url->loc=$gJCoord->request->getServerURI(). $loc;
		}

[laurentj]

a true patch with unit tests may be better ;-)

[laurentj]

Theses days, where HTTPS is now mandatory on every web site, and even browser will force now to use https on page having forms with passwords, it does not make sens to force an url to be http.