developer.jelix.org is not used any more and exists only for history. Post new tickets on the Github account.
developer.jelix.org n'est plus utilisée, et existe uniquement pour son historique. Postez les nouveaux tickets sur le compte github.

Opened 13 years ago

Closed 13 years ago

#446 closed bug (fixed)

links to overlays in xul files are not escaped

Reported by: laurentj Owned by: laurentj
Priority: normal Milestone: Jelix 1.0.2
Component: jelix:core response Version: 1.0.1
Severity: minor Keywords: firefox3
Cc: Blocked By:
Blocking: Documentation needed:
Hosting Provider: Php version:

Description

in Firefox3, overlays are not loaded when the url contains a unescaped characters like &. For example :

<?xul-overlay href="index.php?module=xb_auth&action=xuladmin:xaovlay" ?>

The overlay is not loaded. But if we put

<?xul-overlay href="index.php?module=xb_auth&amp;action=xuladmin:xaovlay" ?>

it is loaded.

Change History (7)

comment:1 Changed 13 years ago by laurentj

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in the trunk and 1.0.x branch.

comment:2 Changed 13 years ago by Julien

Hello,

I just submitted a patch about xul overlays (ticket #451) and noticed that escaped urls for overlays do not seem to work in firefox 2 (mine is Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; fr; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11)

If i remove url escaping, then the overlay is applied.

I don't have any solution to that "bug" yet :(

comment:3 Changed 13 years ago by laurentj

  • Resolution fixed deleted
  • Status changed from closed to reopened

I made tests with firefox 2 and didn't notice bugs... I will made additional tests.

comment:4 Changed 13 years ago by Julien

I also made tests on following versions of Firefox (all extensions disabled, new fresh profile) :

  • Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
  • Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8.1.11) Gecko/20071204 Ubuntu/7.10 (gutsy) Firefox/2.0.0.11

On both of them, the overlay isn't applied if the "&" char is escaped to "&amp;"

comment:5 Changed 13 years ago by laurentj

Ok. I made other tests and you are right.

So the solution I see is only to do browser sniffing, and to check the version of gecko. I made new modification in jResponseXUL in the trunk and 1.0.x branch. Now it works.

I'm waiting for your confirmation that all work now, before to close the ticket.

comment:6 Changed 13 years ago by Julien

Hello,

It seems to work here. Thanks for the fix !

comment:7 Changed 13 years ago by laurentj

  • Resolution set to fixed
  • Status changed from reopened to closed

Thanks for the feedback.

Note: See TracTickets for help on using tickets.