developer.jelix.org is not used any more and exists only for history. Post new tickets on the Github account.
developer.jelix.org n'est plus utilisée, et existe uniquement pour son historique. Postez les nouveaux tickets sur le compte github.

Opened 12 years ago

Closed 12 years ago

#515 closed enhancement (fixed)

jInstallChecker should not warn about magicquotes if the plugin magicquotes is activated

Reported by: Julien Owned by: bastnic
Priority: normal Milestone: Jelix 1.0.3
Component: jelix:utils Version: 1.0.2
Severity: minor Keywords:
Cc: Blocked By:
Blocking: Documentation needed: no
Hosting Provider: Php version:

Description

When magicquotes is enabled in PHP config, jInstallChecker reports that we should disable it or enable the magicquotes plugin.

With my first tests, when the plugin is enabled, the warning is still there in the default page after app creation.

I think we should check magicquotes setup in config files, and if it's the case, do not send this warning.

Attachments (2)

patch-515.diff (2.8 KB) - added by bastnic 12 years ago.
patch-515.2.diff (4.0 KB) - added by bastnic 12 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 12 years ago by laurentj

  • Component changed from jelix to jelix:utils
  • Severity changed from normal to minor

ok. but even if the magicquotes plugin is activated, jInstallChecker should inform that it is better to deactivate magicquotes in php.ini, if possible.

comment:2 Changed 12 years ago by Julien

Ok, so we can imagine sending a warning if the plugin isn't activated, and only some king of notice if the plugin is up.

That notice would say something like : "ok, you enabled the magicquotes plugin so everything will work fine, but it is better to turn of magic quotes in you PHP config is you can".

So we may have 3 levels of notices :

  • Errors << fatal
  • Warnings << not sure everything will work as expected
  • Notices / Suggestions << everything will work, but can still be improved

comment:3 Changed 12 years ago by bastnic

  • Owner set to bastnic
  • Status changed from new to assigned

ok I take that.

Changed 12 years ago by bastnic

comment:4 Changed 12 years ago by bastnic

  • Milestone set to Jelix 1.0.3
  • review set to review?

If I well understood the problem, this patch correct it.

comment:5 Changed 12 years ago by laurentj

  • review changed from review? to review-
+        $defaultconfig = parse_ini_file(JELIX_APP_CONFIG_PATH."defaultconfig.ini.php");

First, you should indicate the second parameter, at true. If there are several "magicquotes" options in the config file, you will have a wrong test ;-)

Second, you should test both thing at the same time : in the configuration files, and in the php settings. The test is ok only when there are magicquotes php + magicquotes plugin, or when there are both off. If one of them is on but not the other, this is an error.

Third, you should read also other configuration file : index/config.ini.php &co.

Changed 12 years ago by bastnic

comment:6 Changed 12 years ago by bastnic

  • review changed from review- to review?

comment:7 Changed 12 years ago by laurentj

  • review changed from review? to review+

It's ok, however, there are some tabulation. Replace it by spaces ;-)

comment:8 Changed 12 years ago by laurentj

  • Resolution set to fixed
  • Status changed from assigned to closed

patch landed in the trunk and 1.0.x branch.

Note: See TracTickets for help on using tickets.