developer.jelix.org is not used any more and exists only for history. Post new tickets on the Github account.
developer.jelix.org n'est plus utilisée, et existe uniquement pour son historique. Postez les nouveaux tickets sur le compte github.

Opened 13 years ago

Closed 13 years ago

#520 closed bug (fixed)

the default zone created with newapp is called on each new controller

Reported by: bastnic Owned by: bastnic
Priority: normal Milestone: Jelix 1.0.3
Component: jelix-scripts Version: 1.0.2
Severity: minor Keywords:
Cc: Blocked By:
Blocking: Documentation needed: no
Hosting Provider: Php version:

Description

This call is made without any condition. So we found this in each controller. Should be conditional

// this is a call for the 'welcome' zone after creating a new application
// remove this line
$rep->body->assignZone('MAIN', 'jelix~check_install');

Attachments (1)

patch-520.diff (6.1 KB) - added by bastnic 13 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 13 years ago by bastnic

  • Status changed from new to assigned

Changed 13 years ago by bastnic

comment:2 Changed 13 years ago by bastnic

  • review set to review?

comment:3 Changed 13 years ago by laurentj

  • review changed from review? to review+
  • Severity changed from normal to minor

Ok, mais faire juste quelques changements avant commit :

+    public  $allowed_options=array('-cmdline'=>false, '-defaultzone'=>false);

Je prefère nommer cette option -addinstallzone. C'est plus parlant.

+    -defaultzone (facultatif) : créer la zone correspondant à une nouvelle application

"Ajoute la zone check_install pour une nouvelle application" (faire la même modif en l'anglais)

Tu as oublié aussi de mettre à jour le lib/jelix-scripts/CREDITS et les entêtes des fichiers modifiés ;-)

comment:4 Changed 13 years ago by bastnic

  • Resolution set to fixed
  • Status changed from assigned to closed

fixed in #833 both in trunk and branches/1.0.x

Note: See TracTickets for help on using tickets.