jZipCreator : empty dirs are not included in the archive

[Julien]

When we add directories in an archive using jZipCreator, empty dirs (ie without files inside) are not added.

I will add a new public method called addEmptyDir($name) wich will allow to add an empty dir.

The existing addDir() method will also be fixed (will call addEmptyDir() when needed) to include empty dirs.

[Julien]

patch with empty dirs support

[Julien]

There's a new public method called addEmptyDir(). It uses quite the same code used for file addition, but external attributes are set to 16 instead of 32.

I found this value from some threads about zip files usage in python.

It seems that we can also use 48 instead of 16, but I don't see any difference.

[laurentj]

Ok, it seems ok to me, although you could do factorization between addContentFile and addEmptyDir, since most of their line codes are same.

Don't forget to update CREDITS files.

Apply your patch on the 1.0.x branch and on the trunk.

Thanks for this patch :-)

[Julien]

Ok I'll try refactoring the code before applying the patch.

[Julien]

updated, improved, factorized patch

[Julien]

I improved the patch. Works like the old one, but the code is cleaner and there are some improvements inside.

Also fixed a bug when adding emptydirs, dirs (recursive) and virtual files at the same time.

working action code :

function zip(){
    $rep = $this->getResponse('zip');
    $rep->zipFilename = 'myCrazyPackage.zip';
    $rep->content->addContentFile('dynamic.txt', 'contenu généré comme on veut');
    $rep->content->addDir(dirname(__FILE__).'/../','',true);
    $rep->content->addEmptyDir('tata');
    return $rep;
}

Laurent, Ok for the commit, or would you like to test it again ?

[laurentj]

ok

[Julien]

commited