Timezone in jelix config file

[doubleface]

Would it be possible to let PHP "guess" the timezone if no timezone is specified in jelix config file? I actually need it for my project and for the moment, I have to patch Jelix for every update(I know exactly on which machine and which os the application will be deployed). I don't think it would be a problem since the timezone is defined in defaultconfig.ini.php.

See the small patch, which was made on the "dev" version (no access to the svn repository from work).

[doubleface]

patch on jCoordinator

[laurentj]

The patch should be made on jConfigCompiler instead, so date_default_timezone_get() will be called only one time.

[doubleface]

That is a good idea.

Here is the patch, but made from the repository this time (retrieved the file from trac).

I tested it only without the jelix extension.

[doubleface]

Same modification, but in jConfigCompiler

[doubleface]

I forgot to add that, this time, the date_default_timezone_get is made if the timeZone key exists in config file, but is empty. This is more flexible. With the previous patch, you couldn't erase a key if it was valued in defaultconfig.ini and the you had to modify it, too.

I think, this timeZone should be empty in defaultconfig.ini instead of Europe/Paris? (to be more international ;-) ).

[laurentj]

The patch is ok

this timeZone should be empty in defaultconfig.ini instead of Europe/Paris? (to be more international

ok I agree, so erase the value of timeZone in lib/jelix/core/defaultconfig.ini.php and in lib/jelix-scripts/templates/var/config/defaultconfig.ini.php.tpl

[bballizlife]

So here we can commit the patch, just adding to it the fact of emptying the timeZone values in lib/jelix/core/defaultconfig.ini.php and in lib/jelix-scripts/templates/var/config/defaultconfig.ini.php.tpl ?

[doubleface]

Yes, I forgot to qdd it in the patch. Can someone commit the patch for me? I still don't have internet at home and no possiblity to commit from work (proxy à la con).

Replying to bballizlife:

So here we can commit the patch, just adding to it the fact of emptying the timeZone values in lib/jelix/core/defaultconfig.ini.php and in lib/jelix-scripts/templates/var/config/defaultconfig.ini.php.tpl ?

[laurentj]

Commited in the trunk.

[laurentj]

In fact, there is a problem. On my machine, date_default_timezone_get() generate a warning :

<b>Strict Standards</b>:  date_default_timezone_get() : It is not safe to rely on the system's timezone settings. Please use the date.timezone setting, the TZ environment variable or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected 'Europe/Berlin' for 'CEST/2.0/DST' instead in <b>jelix/tests/trunk/lib/jelix/core/jConfigCompiler.class.php</b> on line <b>90</b><br />

so I replace the call date_default_timezone_get() by :

        if (trim($config->timeZone) === '') {
#if PHP50
            $config->timeZone = "Europe/Paris";
#else
            $tz = ini_get('date.timezone');
            if ($tz != '')
                $config->timeZone = $tz;
            else
                $config->timeZone = "Europe/Paris";
#endif
        }