jTPL - date_format modifier doesn't accept TS

[CreatixEA]

The modifier date_format doesn't accept timestamps :

function jtpl_modifier_common_date_format( $string, $format="%b %e, %Y",
                                    $default_date=null) {

    if (substr(PHP_OS,0,3) == 'WIN') {
        $_win_from = array ('%e',  '%T',	   '%D');
        $_win_to   = array ('%#d', '%H:%M:%S', '%m/%d/%y');
        $format	= str_replace($_win_from, $_win_to, $format);
    }

    if($string != '') {

        return strftime($format, strtotime($string));

    } elseif (isset($default_date) && $default_date != '') {

        return strftime($format, strtotime($default_date));

    } else {

        return '';
    }
}

The string is parsed using strtotime, timestamps are long... then strtotime(ALongNumber) returns 01/01/1970 ...

[laurentj]

Could you explain what happen precisely ? I don't understand your problem. Have you got an example which doesn't work ?

[foxmask]

le probleme se produit quand on fait ceci :

toto est vide donc $now va etre utilise à la place mais $now est un timestamp et le modifier ne peut pas gerer celui ci avec strtotime :

{assign $toto=''}
{assign $now = time()}
{$toto|date_format:"%b %e, %Y":$now}

un patch suit ;)

[foxmask]

patch pour le modifier date_format

[laurentj]

ok, but I also improved a bit the code of this plugin. ​http://hg.jelix.org/jelix/jelix-trunk/rev/881e94d5d8a8

Note that, for the current time, you can pass "now" to strtotime, so, in the 1.1.x branch, you can do

{$toto|date_format:"%b %e, %Y":"now"}