jIRestController must be PUT friendly

[greut]

You cannot gets the params send with a PUT call from the jController usual $this->param("..."); without this little hack. Can you consider moving this into jController? (It's only required for PUT, yeah PHP isn't that REST friendy ;-D)

<?php

class restCtrl extends jController implements jIRestController {

    function put(){
        $_PUT = array();
        parse_str(file_get_contents("php://input"), $_PUT);
        $this->request->params = array_merge($this->request->params, $_PUT);
        //...
    }

}}}}

Thanks a lot.

[greut]

I've ended up with a more complex hack, since the REST client is using curl (from PHP) and sends a multipart/form-data within the body.

<?php
// […]
    function put() {
        $_PUT = array();
        $input = file_get_contents("php://input");
        if(strpos($_SERVER["CONTENT_TYPE"], "multipart/form-data") > -1) {
            list($_, $boundary) = explode("=", $_SERVER["CONTENT_TYPE"], 2);
            $vars = explode($boundary, $input);
            foreach($vars as $var) {
                $var = trim($var);
                if($var !== "--") {
                    list($name, $value) = explode("\r\n\r\n", $var);
                    if(preg_match('/.*?name="([^"]+)"/i', $name, $matches)) {
                        $_PUT[$matches[1]] = $value;
                    }
                }
            }
        } else {
            parse_str($input, $_PUT);
        }
        $this->request->params = array_merge($this->request->params, $_PUT);
    }

But this is so ugly that I think I'm doin' it wrong.

[laurentj]

premiere version du patch

[laurentj]

I've just create a first patch which is a better integration into Jelix than your's.

However, The parsing of a multipart/form-data content is not a full implementation of the specification (RFC 2388), so we have to improve it. It could be interesting to support files into multipart/form-data, so files could be handled like PHP does for POST (content saved in temporary files, and $_FILES is filled with informations of this files).

For the gold edition, perhaps we can create a function in the PHP extension of Jelix, which could call the internal API of the PHP engine, which parses multipart/form-data contents.

Another point on which I should study: should we have a specific request object to support REST or not...

[greut]

petit correctif, de la première version du patch (qui ne casse pas mon application existante)

[greut]

Thanks a lot, I can clean up a little my application now.

To have it working properly, I had to adapt the fix made to jClassicRequest a little bit (attachment:656_v2.diff​)

To fully supporting the RFC, it could be interesting to have proper tests for that. This is deffo something nice to have. I don't think getting $_PUT is tied to REST only and I didn't make other funky workaround to have something that work.

Cheers,

-- Yoan

PS: s/Greut/Yoan Blanc/g ;-)

[laurentj]

Patch landed ​http://hg.jelix.org/jelix/jelix-trunk/rev/a148b21f1e63

[laurentj]

doc done ​http://jelix.org/articles/fr/manuel-1.2/restfull#cas-du-put ​http://jelix.org/articles/en/manual-1.2/restfull#the-put-case