jForms: always include jQuery when using HTML builder

[Julien]

Right now, jQuery is only included when we need Wymeditor. But changes in #687 make it needed for every form. This is not a problem, because we'll need it to support datepicker in forms too (#196}.

So I suggest including jQuery for every jForm Html rendering.

[Julien]

blocking #687 because committing #687 without committing this ticket will break jforms.js

[laurentj]

should we really include jquery everytime we use the html builder of jquery ? that is the question. Because even for little forms, we will have 55ko of javascript loaded in the page...

we have to discuss about that point...

[Julien]

maybe I could write the patches another way, but I think we should remember :

• jquery.js will be cached in browsers
• jQuery is needed by Wymeditor, the future datepicker, ajax for jForms, etc...

So I think that default inclusion may be a really good thing that does not cost that much perf.

Maybe we should write an alternative builder ? The problem is that #687 make jforms.js require jQuery for triggering pre-check event. So we may need 2 jforms.js, one for each builder.

Or jforms.js could check jQuery availability before binding that event ?

[laurentj]

Ok, we decided to include jQuery for the html builder. But at the same time, I would like a htmllight builder.

I'm currently creating this htmllight builder and integrate your patch...

[Julien]

Laurent,

just added a variant of the patch for #687

It does not make jQuery required thanks to a simple test on jQuery function presence in jforms.js

So the current ticket may be invalid.

I say that, because if you write a htmllight builder, you will still need to check for jQuery availability in jforms.js, or have a jforms-ligh.js or something....

So please take a look at the second version of the patch for #687, it may save your time ;)

[laurentj]

because if you write a htmllight builder, you will still need to check for jQuery availability in jforms.js, or have a jforms-ligh.js or something....

Yes, I know ;-)

it may save your time

too late...

[Julien]

Replying to laurentj:

too late...

;(

we'll see the differences between both builders. If the only difference is the default inclusion of jQuery, maybe second version of the #687 patch is still better...

[laurentj]

Done. Commited in the trunk.

the html builder now includes always jquery and has its own javascript file, jforms_jquery.js. A new builder, htmllight, won't use jquery except for the html editor, and have its own javascript file jforms_light.js

we can now improve jforms_jquery.js to use all features we need of jquery. And you can patch jforms_light.js to fix bug #687.

[Julien]

ok, I just made a third version of the patch for #687