developer.jelix.org is not used any more and exists only for history. Post new tickets on the Github account.
developer.jelix.org n'est plus utilisée, et existe uniquement pour son historique. Postez les nouveaux tickets sur le compte github.

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#691 closed bug (fixed)

jForms: radiobutton with value 0 should not get selected by default

Reported by: Julien Owned by: Julien
Priority: normal Milestone: jelix 1.1
Component: jelix:forms Version: trunk
Severity: normal Keywords:
Cc: Blocked By:
Blocking: Documentation needed: no
Hosting Provider: Php version:

Description

In the code, 0 value and no value are considered as the same thing, so the radiobutton with value="0" gets selected by default.

So just made a strict comparison between values.

Attachments (4)

691-jForms-radiobutton-with-value-0-should-not-get-selected-by-default.diff (1.8 KB) - added by Julien 12 years ago.
691-jForms-radiobutton-with-value-0-should-not-get-selected-by-default.2.diff (986 bytes) - added by Julien 12 years ago.
little mistake in previous patch fixed
691-jForms-radiobutton-with-value-0-should-not-get-selected-by-default.3.diff (2.0 KB) - added by Julien 12 years ago.
dammit, forgot one file in the diff ! this is the good one !
691-jForms-radiobutton-with-value-0-should-not-get-selected-by-default.4.diff (6.1 KB) - added by Julien 12 years ago.
patch with updated unit-tests

Download all attachments as: .zip

Change History (13)

comment:1 Changed 12 years ago by Julien

  • Status changed from new to assigned
  • Summary changed from jForms: radiobutton with value 0 gets selected by default, and it should'nt to jForms: radiobutton with value 0 should not get selected by default

Changed 12 years ago by Julien

little mistake in previous patch fixed

Changed 12 years ago by Julien

dammit, forgot one file in the diff ! this is the good one !

comment:2 Changed 12 years ago by laurentj

it seems ok, but again, unit tests are missing. Perhaps you've broke some tests...

comment:3 Changed 12 years ago by Julien

Ok I'll make some tests for that too ;)

comment:4 Changed 12 years ago by laurentj

  • Milestone set to Jelix 1.1 beta 2

comment:5 Changed 12 years ago by laurentj

  • review review? deleted

Changed 12 years ago by Julien

patch with updated unit-tests

comment:6 Changed 12 years ago by Julien

  • review set to review?

comment:7 Changed 12 years ago by laurentj

  • review changed from review? to review+

comment:8 Changed 12 years ago by Julien

  • Resolution set to fixed
  • Status changed from assigned to closed

committed in the trunk

comment:9 Changed 12 years ago by laurentj

  • Milestone changed from Jelix 1.1 beta 2 to jelix 1.1

Milestone Jelix 1.1 beta 2 deleted

Note: See TracTickets for help on using tickets.