support external absolute url as jform action

[bibo]

If someone wants to post data to a web service, it would be cool to still do it through jforms. At now, jforms throws an exception if you give an absolute url as jform action.

Note that, although it will be cool, you should take care of cleaning jform session data when the service pings you back. Otherwise, you'll pile up unused session data...

[bibo]

like this ?

[bibo]

fixes warnings

[laurentj]

+            if (count($this->_actionParams)>0)
+                $url = jUrl::appendToUrlString($this->_action, $this->_actionParams, true);
+            echo '<form action="',$url,'" method="'.$this->options['method'].'" id="', $this->_name,'"';

I think that, in the case of method="get", _actionParams value should be inserted into <input type="hidden">.

[bibo]

You mean method="*post*", I presume, no ?

[laurentj]

non, "get". In a form, the parameters of the url should be into fields.

[bibo]

another try

[bibo]

patch updated to tip

[laurentj]

+        if( ($externalUrl && count($this->_actionParams)>0) )
+           $params = $this->_actionParams;
+        else
+           $params = $url->params;

In the case of external url, $url is a string, not an object. So if we give an external url without parameters, we enter in the second part of the condition, and we will have an error. I think that you should remove the test about the count.

+        if ($externalUrl = preg_match('/^http:\/\//',$this->_action)) {
+            $url = $this->_action;

And then I think the assignation of $url is useless here. I think also that the assignation of the $params could be done in this if statement, and not in a separate if statement.

+        foreach (params as $p_name => $p_value) {

a $ is missing

Same comments for htmllight.jformsbuilder.php + you forgot to change the foreach($url->params..)

[bibo]

simpler

[bibo]

and perhaps correct :)

[laurentj]

It's ok :-)

[Julien]

Hello,

shouldn't we support httpS too ?

so we could write this :

if (preg_match('#^https?://#',$this->_action)) { 

[laurentj]

Yes, I agree.

[Julien]

I'm doing it right now + unit tests

[Julien]

support of https and unit tests

[laurentj]

it's ok, thank you :-)

[Julien]

dammit ! wrong commit message ! switched 2 tickets in my mind ! (any way to change this ?) sorry for that.

commit done in the trunk, svn r1176

[laurentj]

I changed the log message :-)