developer.jelix.org is not used any more and exists only for history. Post new tickets on the Github account.
developer.jelix.org n'est plus utilisée, et existe uniquement pour son historique. Postez les nouveaux tickets sur le compte github.

Opened 12 years ago

Closed 12 years ago

#718 closed bug (fixed)

jForms: space only values on required fields do not fire errors

Reported by: bibo Owned by: laurentj
Priority: high Milestone: Jelix 1.0.6
Component: jelix:forms Version: 1.0.5
Severity: major Keywords:
Cc: Blocked By:
Blocking: Documentation needed: no
Hosting Provider: Php version:

Description

And I think it should... jForms should trim values (client and server side) before doing checks.

Attachments (2)

#718-trunk-spaces-donotfire-errors.patch (3.9 KB) - added by bibo 12 years ago.
patch against trunk only
#718-trunk-spaces-donotfire-errors.2.patch (6.2 KB) - added by bibo 12 years ago.
v2 with unit tests

Download all attachments as: .zip

Change History (14)

comment:1 Changed 12 years ago by bibo

  • Version 1.0.5 deleted

comment:2 Changed 12 years ago by bibo

This was found on trunk but I can't tell if jelix v1.0.5 beahves the same.

comment:3 Changed 12 years ago by Julien

I agree with that, would you write a patch ?

comment:4 Changed 12 years ago by laurentj

  • Priority changed from normal to high
  • Severity changed from normal to major

comment:5 Changed 12 years ago by bibo

I take it.

Changed 12 years ago by bibo

patch against trunk only

comment:6 Changed 12 years ago by bibo

this patch is only against trunk as i don't have the 1.0.5 branch. It passes unit tests except the one added in ticket #713 but it is not related.

I will add some unit tests for this bug later.

comment:7 Changed 12 years ago by bibo

  • review set to review+

comment:8 Changed 12 years ago by bibo

  • review changed from review+ to review?

oops

comment:9 Changed 12 years ago by laurentj

  • Milestone set to Jelix 1.0.6
  • review changed from review? to review+
  • Version set to 1.0.5

it's ok.

I think there is the same problem on the 1.0.x branch.

Changed 12 years ago by bibo

v2 with unit tests

comment:10 Changed 12 years ago by bibo

I've checked the patch in trunk. Could someone adapt and land this one on branch 1.0.5 svp ?

comment:11 Changed 12 years ago by laurentj

  • Owner changed from bibo to laurentj
  • Status changed from new to assigned

I take it.

comment:12 Changed 12 years ago by laurentj

  • Resolution set to fixed
  • Status changed from assigned to closed

done.

Thanks for the patch.

Note: See TracTickets for help on using tickets.