developer.jelix.org is not used any more and exists only for history. Post new tickets on the Github account.
developer.jelix.org n'est plus utilisée, et existe uniquement pour son historique. Postez les nouveaux tickets sur le compte github.

Opened 12 years ago

Closed 12 years ago

#746 closed bug (fixed)

testapp: problems when stripping comments

Reported by: Julien Owned by: Julien
Priority: normal Milestone: jelix 1.1
Component: app:testapp Version: trunk
Severity: critical Keywords:
Cc: Blocked By:
Blocking: Documentation needed: no
Hosting Provider: Php version:

Description

I just noticed ugly bugs when building testapp. I took me a while to find out why.

since r1175, the build process strips out the comments by default.

It's a big problem for config files, as we get :

;<?php /* comments & extra-whitespaces have been removed by jBuildTools*/
die(''); ?>

which will produce parse errors

We could prefix theses files with "!" in the manifests (see the attached patch for testapp)

Once solved, the problem also appeared in unit tests about soap and wsdl, because wsdl NEEDS comments of methods to work !

So again, prefixing with "!" in the manifest would work.

Then, I don't know if any other file may encounter this problem, all unit tests pass with the patch applied.

So we must remember (and write somewhere) that every php file that REQUIRE comments to work must be prefixed with "!" in manifests.

Attachments (1)

746-testapp-problems-when-stripping-comments.diff (1.6 KB) - added by Julien 12 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 12 years ago by Julien

  • Status changed from new to assigned

comment:2 Changed 12 years ago by laurentj

  • review changed from review? to review-

No, the error is in the buildapp.php. Remove the "true" parameter added in r 1175. It's my fault.

comment:3 Changed 12 years ago by Julien

  • Resolution set to fixed
  • Status changed from assigned to closed

ok, committed in the trunk, r1179

Note: See TracTickets for help on using tickets.