scripts: createapp -wwwpath "somepath" doesn't work under windows

[bibo]

the culprit is realpath which is called to obtain a canonical absolute path. Under windows, it returns an empty string if the path does not exist...

So we should implement our own version, instead.

[bibo]

implement our own version of realpath

[bibo]

my patch adds a getCanonicalPath to the base command class. this fixes the problem under windows and still work well under linux/unix.

note: this patch solves also #775

[laurentj]

If the function is imported from clearbricks, then you forgot to include the copyright, authors, licence in the header of the function.

However, perhaps it could be better to include the original file in lib/clearbricks/ if there isn't too much dependencies with other files of clearbricks, and if we can call this methods without instancying thousand of classes :-)

[bibo]

I hadn't already asked review but lucky luke laurentj fires faster than his svn tool :)

Now, I've look more thoroughly into lib.files.php of clearbricks. This brings a lot of methods Jelix doesn't have. It seems to have no dependance at all. I suggest to inherit from it and expose those methods through jFile API.

thoughts ?

[bibo]

Well, files class has one dependance. Also, some of its methods intersects with jFile methods.

We have to patch lib.files.php to add it to Jelix. I will post a patch that :

• get rid of the dependance
• hide methods in files class already implemented by jFile

[bibo]

take two, include lib.files.php in Jelix and expose its api through jFile

[bibo]

take two, include lib.files.php in Jelix and expose its api through jFile.

I had to patch lib.files.php a bit since some methods are redundant with existing one in jFile. I also commented tidyFilename method which induced a dependance.

In jFile, I've added a wrapper around path::real method. I didn't want to bother creating another utility say jDir. Maybe on a future spin....

patch still solves #775.

[laurentj]

fixed in the trunk+1.1.x. r1237.

I didn't extends jFile from the file class, since it includes many methods which isn't used by the core (jFile is used in the core).