developer.jelix.org is not used any more and exists only for history. Post new tickets on the Github account.
developer.jelix.org n'est plus utilisée, et existe uniquement pour son historique. Postez les nouveaux tickets sur le compte github.

Opened 10 years ago

Closed 10 years ago

#822 closed bug (fixed)

Bug entre jcommunity et la nouvelle admin

Reported by: geekbay Owned by: bibo
Priority: normal Milestone: Jelix 1.1.2
Component: jelix:events Version: 1.1RC3
Severity: normal Keywords:
Cc: Blocked By:
Blocking: Documentation needed: no
Hosting Provider: Php version:

Description

Pour expliquer le probleme voici ma configuration: j'ai donc 2 entrypoint index.php et admin.php jcommunity n'est utilise que par index et dans le fichier var/config/admin/config.ini.php j'ai:

checkTrustedModules = on trustedModules = "jacl2db,jauth,jacl2db_admin,jauthdb_admin,master_admin,admin" unusedModules = "jcommunity"

quand je me log j'ai le message d'erreur suivant:

Fatal error: jEvent::require_once() [function.require]: Failed opening required 'classes/authcommunity.listener.php' (include_path='.:/usr/share/php:/usr/share/pear') in /var/www/lib/jelix/events/jEvent.class.php on line 178

Si j'enleve unusedModules alors la on l'erreur suivante:

[notice 8] Undefined property: cDaoRecord_jauth_Jx_jelixuser_Jx_mysql::$status /var/www/app/modules/jcommunity/classes/authcommunity.listener.php 19

Donc il semble bien que le listener repond au event au moment ou on se log (normal puisque il repond au event onAuthCanLogin) dans l'admin meme si il est dans un module mis en unused

Attachments (2)

#822-trunk-events-donotinclude-unused-modules.patch (1.3 KB) - added by bibo 10 years ago.
fixes ? only trunk for the moment
#822-trunk-events-donotinclude-unused-modules.2.patch (1.8 KB) - added by bibo 10 years ago.
updated after laurentj perf comments

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by foxmask

pour info en passant.

onAuthCanLogin

est une reponse à l'event AuthCanLogin? du module jAuth pas de jCommunity.

si ça peut servir ;)

comment:2 Changed 10 years ago by foxmask

J'ai peut être trouve un effet de bord. J'ai mis mon pb sur le forum

comment:3 Changed 10 years ago by laurentj

  • Component changed from jelix to jelix:events
  • Milestone set to Jelix 1.1.2

Changed 10 years ago by bibo

fixes ? only trunk for the moment

comment:4 Changed 10 years ago by bibo

  • Owner set to bibo
  • review set to review?

comment:5 Changed 10 years ago by laurentj

  • review changed from review? to review-

it's better to use isset($modules[$module]) instead of in_array, for performance reasons. And assign by ref.

$modules = & $GLOBALS['gJConfig']->_modulesPathList; 

Changed 10 years ago by bibo

updated after laurentj perf comments

comment:6 Changed 10 years ago by bibo

  • review changed from review- to review?

unit tests are ok

comment:7 Changed 10 years ago by laurentj

  • review changed from review? to review+

ok. Just a thing to improve : since we have now a $modules variable, we can use it also with the require_once instruction (line 182/185) ;-)

comment:8 Changed 10 years ago by bibo

  • Resolution set to fixed
  • Status changed from new to closed

commited r1345. including latest nits from laurent.

landed on trunk and branch Thanks laurent for the quick review :)

Note: See TracTickets for help on using tickets.