jDao conditions: field names should be enclosed in some db engines

[Julien]

In a table, I wanted to use a field named "order", but I had errors when using it in jDaoConditions.

So in some db engines, we need to escape those field names, like the way they are with generated dao methods with jDaoGenerator.

So I propose a new method: jDbConnection::encloseFieldName($fieldName) to deal with this.

[Julien]

Please note: lib/jelix/plugins/db/mysql/mysql.dbconnection.php seems to have lots of change, but that's because indentation was not correct (3 spaces instead of 4).

The only thing that is new is:

/**
 * enclose the field name
 * @param string $fieldName the field name
 * @return string the enclosed field name
 * @since 1.1
 */
public function encloseFieldName($fieldName){
    return '`'.$fieldName.'`';
}

[laurentj]

bad version in @since tags : it is 1.1.1, not 1.1

[Julien]

Replying to laurentj:

bad version in @since tags : it is 1.1.1, not 1.1

oops, changed this ;)

committed in the trunk and 1.1.x, r1315

should I do something similar in 1.0.x ?

[thomas]

Il faut rajouter la méthode encloseFieldName dans la classe jDbPDOConnection aussi.

[Julien]

ok, done it, works fine. I'm also writing unit tests, then submit a patch

[Julien]

here it is

[laurentj]

ok

[Julien]

committed in the trunk and 1.1.x, r1338

[laurentj]

I just renamed the method to encloseName, because it can be use to enclose table name too. r1340