developer.jelix.org is not used any more and exists only for history. Post new tickets on the Github account.
developer.jelix.org n'est plus utilisée, et existe uniquement pour son historique. Postez les nouveaux tickets sur le compte github.

Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#903 closed bug (fixed)

jUrl: significant engine: multiple modules without action for a unique entrypoint

Reported by: Julien Owned by: Julien
Priority: normal Milestone: Jelix 1.2 beta
Component: jelix:plugins Version: trunk
Severity: normal Keywords:
Cc: Blocked By:
Blocking: Documentation needed: no
Hosting Provider: Php version:

Description

for description (in french): http://jelix.org/forums/read.php?5,4941

The goal is to have an equivalent on

[simple_urlengine_entrypoints]
admin="jacl2db~*@classic, jauth~*@classic, jacl2db_admin~*@classic, jauthdb_admin~*@classic, master_admin~*@classic"

in the significant engine.

NB: maybe there's no bug and I just couldn't find the right way to do it...

Attachments (1)

Change History (8)

comment:1 Changed 12 years ago by Julien

  • Status changed from new to assigned

Here's a patch that solves the issue.

If we have more than one module without specified action on a unique entrypoint, then we do not remove the "module" parameter when building the url.

unit tests from testapp do pass.

comment:2 Changed 12 years ago by laurentj

  • Documentation needed set
  • Milestone changed from Jelix 1.1.3 to Jelix 1.2
  • Resolution set to fixed
  • review changed from review? to review-
  • Status changed from assigned to closed

I don't like this _canRemoveModule method, because it not very good for performance. The informations generated by the parser should contains a boolean to indicate if the parameter should be removed or not.

And unit tests are missing.

I landed an other patch and only on the trunk.

comment:3 Changed 12 years ago by laurentj

r1389

comment:4 Changed 12 years ago by Julien

This works fine, thanks to Thomas and you.

comment:5 Changed 12 years ago by laurentj

oups, bad name, it's not thomas, but you, since I take some few lines of code of your patch :-).

I should not work so late in the night :-)

comment:6 Changed 12 years ago by Julien

lol, so thanks to myself ;)

working late at night -> same for me, but in the morning. Nothing good comes before 11AM ;)

Note: See TracTickets for help on using tickets.