developer.jelix.org is not used any more and exists only for history. Post new tickets on the Github account.
developer.jelix.org n'est plus utilisée, et existe uniquement pour son historique. Postez les nouveaux tickets sur le compte github.

Opened 8 years ago

Closed 7 years ago

#986 closed task (fixed)

PHP unit integration

Reported by: laurentj Owned by: laurentj
Priority: high Milestone: Jelix 1.3 beta 1
Component: jelix Version:
Severity: normal Keywords:
Cc: doubleface Blocked By:
Blocking: Documentation needed: no
Hosting Provider: Php version:

Description

Christophe's work on the integration of phpunit into Jelix could be now integrated.

I already started this merge on my own branch. It is almost finished. I just have to update tests now.

Change History (7)

comment:1 Changed 8 years ago by doubleface

Here is the list of things missing (I think) :

  • Web interface (I'm on it for an equivalent of the simpletest interface)
  • Help for cli interface
  • migration of the phpunit repository to the trunk (laurent seems to be on it). The current one is for Jelix 1.1.
  • ... the documentation in the wiki

Some other ideas ?

comment:2 Changed 8 years ago by laurentj

In fact, I have to include also your latest commit from the hg repository. I didn't see that you worked on it last days :-) (I included only changes from the svn repository, because I had only this copy on my laptop).

I didn't verify if you fixed it these last days, but you forgot to include a document comment on top of your files (jphpunit module etc), like those we find in other files of jelix.

comment:3 Changed 8 years ago by doubleface

  • Owner changed from laurentj to doubleface
  • Status changed from new to assigned

comment:4 Changed 8 years ago by laurentj

  • Milestone Jelix 1.2 deleted

comment:5 Changed 7 years ago by laurentj

  • Milestone set to Jelix 1.3
  • Owner changed from doubleface to laurentj
  • Status changed from assigned to new
  • Summary changed from Import PHPunit branch into the trunk to PHP unit integration

Finally, I will integrate phpunit in an other way. I think we should avoid to run phpunit test in a jelix environnement (eg, within a module). It is complicated to test some components with different jelix environnement.

And by providing our own class based on PHPUnit_TextUI_Command, and overloading handleCustomTestSuite, we could avoid rewriting some code to handle all command line options.

So I began a new command line script (that is not a jelix-based scripts). I reuse of course some of components of Christophe.

comment:6 Changed 7 years ago by doubleface

Actually, this method did not exist when I implemented it (a long time ago...). I would be glad to take a look at your code. Any bitbucket repository where I can find it. Maybe I can help.

comment:7 Changed 7 years ago by laurentj

  • Resolution set to fixed
  • Status changed from new to closed

Patch landed: ​https://bitbucket.org/jelix/jelix-trunk/changeset/060862f82ffb

Temporary documentation: ​http://jelix.org/articles/en/manual-1.3-changes#with-php-unit

Note: See TracTickets for help on using tickets.