developer.jelix.org is not used any more and exists only for history. Post new tickets on the Github account.
developer.jelix.org n'est plus utilisée, et existe uniquement pour son historique. Postez les nouveaux tickets sur le compte github.

Opened 11 years ago

Closed 11 years ago

#991 closed bug (fixed)

les droits des groupes sont irrévocables

Reported by: foxmask Owned by:
Priority: normal Milestone: Jelix 1.1.4
Component: module:jacl2db_admin Version: 1.1.3
Severity: normal Keywords:
Cc: Blocked By:
Blocking: Documentation needed: no
Hosting Provider: Php version: 5.3

Description

Depuis le module jelix admin "jacl2db_admin", une fois un droit attribué, il ne peut plus être retiré.

Attachments (3)

jacl2DbManager_ticket_991.patch (1.8 KB) - added by foxmask 11 years ago.
patch pour la branche 1.1
jacl2DbManager_ticket_991.2.patch (2.0 KB) - added by foxmask 11 years ago.
patch pour le trunk
jacl2DbManager_ticket_991.3.patch (1.9 KB) - added by foxmask 11 years ago.
patch pour le trunk (version precedante faussée)

Download all attachments as: .zip

Change History (6)

comment:1 Changed 11 years ago by foxmask

testé en 1.1.x et la version trunk

Changed 11 years ago by foxmask

patch pour la branche 1.1

Changed 11 years ago by foxmask

patch pour le trunk

Changed 11 years ago by foxmask

patch pour le trunk (version precedante faussée)

comment:2 Changed 11 years ago by foxmask

  • review set to review?

comment:3 Changed 11 years ago by laurentj

  • Resolution set to fixed
  • review changed from review? to review-
  • Status changed from new to closed

In the method, we already construct an array which contain rights to remove. So we should use it. In fact, we can optimize by using/modifying directly $oldRights., so we don't have to do an array_diff.

I fixed it and added tests:

However, thank you for your ticket and your patch.

Note: See TracTickets for help on using tickets.